This repository has been archived by the owner on Apr 28, 2022. It is now read-only.
Replace JAEGER_SAMPLER_MANAGER_HOST_PORT with JAEGER_SAMPLING_ENDPOINT #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falco20019
added
enhancement
yurishkuro
reviewed
Feb 14, 2020
yurishkuro
reviewed
Feb 17, 2020
| @@ -31,15 +39,15 @@ internal SamplingStrategyResponse ParseJson(string json) | |||
|
|
|||
| public async Task<SamplingStrategyResponse> GetSamplingStrategyAsync(string serviceName) | |||
| { | |||
| string url = "http://" + _hostPort + "/?service=" + Uri.EscapeDataString(serviceName); | |||
There was a problem hiding this comment.
Interesting, this wasn't using the /sampling endpoint previously? The results from / endpoint are using legacy Thrift-to-JSON conversion that used numbers for enums, instead of strings. Have you tested this change with an agent? I don't think crossdock tests cover the sampling endpoint.
There was a problem hiding this comment.
I checked the code again. The enum is not checked at all, therefore it's not making problems. C# is deserializing the following data structure as property. So it's looking for the field names instead of the enum. But I will adjust the test cases to make sure this reflects the real situation.
If there are no more open points, please approve :)
Closed
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes