-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
@yurishkuro Looking at the I would also propose to add a new environment flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to extend crossdock tests with this mode
This needs to be rebased once #151 was merged. |
As #151 should be merged today or tomorrow, I will recreate this PR in a follow-up since it's easier as rebasing this. |
Which problem is this PR solving?
Short description of the changes
Thrift
. This add a separate packageJaeger.Grpc
(likeJaeger.Thrift
).As discussed in #116, we should invert the dependecy before releasing 0.4.0 so that the user can choose between
Thrift
orGrpc
and does not have to get all the dependencies (or non in case they implementISender
themselves). But this is outside the scope of this PR.