Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

Add GrpcSender for jaeger-collector #141

Closed
wants to merge 6 commits into from
Closed

Conversation

Falco20019
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • The jaeger-collector got an GRPC endpoint. This can be used instead of Thrift. This add a separate package Jaeger.Grpc (like Jaeger.Thrift).

As discussed in #116, we should invert the dependecy before releasing 0.4.0 so that the user can choose between Thrift or Grpc and does not have to get all the dependencies (or non in case they implement ISender themselves). But this is outside the scope of this PR.

@Falco20019 Falco20019 added this to the v0.4.0 milestone Apr 2, 2019
@Falco20019
Copy link
Collaborator Author

@yurishkuro Looking at the collector.proto, I assume we will have a agent.proto in phase 3 of jaegertracing/jaeger#773. My proposal is, to implement the jager-collector GRPC endpoint like we have with the HTTP endpoint for users skipping the jaeger-agent.

I would also propose to add a new environment flag JAEGER_GRPC_MODE to define if contacting jaeger-collector or jaeger-agent. As we only have collector mode right now, I would also spare it for now and just keep it as concept.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to extend crossdock tests with this mode

src/Jaeger/Configuration.cs Show resolved Hide resolved
src/Jaeger/Jaeger.csproj Show resolved Hide resolved
src/Jaeger/Senders/GrpcSender.cs Show resolved Hide resolved
@Falco20019
Copy link
Collaborator Author

This needs to be rebased once #151 was merged.

@Falco20019
Copy link
Collaborator Author

As #151 should be merged today or tomorrow, I will recreate this PR in a follow-up since it's easier as rebasing this.

@Falco20019 Falco20019 closed this Apr 7, 2020
@Falco20019 Falco20019 removed this from the v0.4.0 milestone Apr 14, 2020
@Falco20019 Falco20019 deleted the Falco20019/grpc-sender branch April 16, 2020 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for GrpcSender
3 participants