Fix loading of sampling endpoint address from JAEGER_SAMPLING_ENDPOINT environment variable #200
Conversation
fix conversion to double of JAEGER_SAMPLER_PARAM rename env var JAEGER_SAMPLER_MANAGER_HOST_PORT to JAEGER_SAMPLER_SERVER_URL properly load JAEGER_SAMPLER_SERVER_URL Signed-off-by: CI-Bot for Emmanuel Courreges <[email protected]>
what is the motivation for this? |
|
✅ Build jaeger-client-cpp 78 completed (commit 9dbc84b6a3 by @) |
In the yaml configuration it is named samplingServerURL, and the env variables for samplers started with JAEGER_SAMPLER, so I decided to rename it like that for consistency (and not JAEGER_SAMPLER_SAMPLING_SERVER_URL which is also redundant). Also it is really a URL and not a host:port. |
|
✅ Build jaeger-client-cpp 79 completed (commit a14911fc41 by @) |
ecourreges-orange
force-pushed
the
master
branch
from
2b1c99a to
c40de22
Compare
|
✅ Build jaeger-client-cpp 80 completed (commit b2766e7eaa by @) |
Signed-off-by: CI-Bot for Emmanuel Courreges <[email protected]>
/ or /whatever does not work for this driver: the agent answers slightly differently with a numerical strategyType Signed-off-by: CI-Bot for Emmanuel Courreges <[email protected]>
ecourreges-orange
force-pushed
the
master
branch
from
cbfb00b to
8726682
Compare
|
✅ Build jaeger-client-cpp 81 completed (commit b2766e7eaa by @) |
|
✅ Build jaeger-client-cpp 82 completed (commit e39fee5c02 by @) |
|
✅ Build jaeger-client-cpp 83 completed (commit e39fee5c02 by @) |
|
We had a discussion (jaegertracing/jaeger#1971 (comment)) about the naming, and the preferred name is |
… as per jaegertracing/jaeger#1971 (comment) Signed-off-by: CI-Bot for Emmanuel Courreges <[email protected]>
|
Done renaming the env var |
|
✅ Build jaeger-client-cpp 85 completed (commit ebbfd97987 by @) |
| @@ -36,11 +36,15 @@ void Config::fromEnv() | |||
| const auto param = utils::EnvVariable::getStringVariable(kJAEGER_SAMPLER_PARAM_ENV_PROP); | |||
| if (!param.empty()) { | |||
| std::istringstream iss(param); | |||
| int paramVal = 0; | |||
| double paramVal = 0; | |||
| if (iss >> paramVal) { | |||
| _param = paramVal; | |||
| } | |||
There was a problem hiding this comment.
Probably should log a warning if value cannot be parsed. But it's not in scope for this PR.
yurishkuro
changed the title
fix conversion to double of JAEGER_SAMPLER_PARAM
rename env var JAEGER_SAMPLER_MANAGER_HOST_PORT to JAEGER_SAMPLER_SERVER_URL
properly load JAEGER_SAMPLER_SERVER_URL
Signed-off-by: CI-Bot for Emmanuel Courreges [email protected]