Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the docs per the changes from the spanmetrics processor to spanmetrics connector #632

Closed
wants to merge 2 commits into from

Conversation

jkowall
Copy link
Collaborator

@jkowall jkowall commented Apr 30, 2023

Updating the docs per changes in Otel. I can also add a link to @pavolloffay 's tutorial, might be a good set of examples for users in the doc. Just let me know.

…the spanmetrics connector

Signed-off-by: Jonah Kowall <[email protected]>
@netlify
Copy link

netlify bot commented Apr 30, 2023

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit b2b9b36
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/647d5e5ba01e4d0008795349
😎 Deploy Preview https://deploy-preview-632--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all line endings are changed, while the text changes are minor. Please make sure to keep the original line endings.

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, Jonah. I've added a comment about the timing of this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some breaking changes introduced in the spanmetrics connector. As such, I suggest we address jaegertracing/jaeger#4345 first before we merge this change into documentation.

@jkowall
Copy link
Collaborator Author

jkowall commented May 2, 2023

It looks like all line endings are changed, while the text changes are minor. Please make sure to keep the original line endings.

I am not sure what you mean by line endings? I am also not sure why the full file changed when I only edited a few things. Probably has to do with copying files around.

@yurishkuro
Copy link
Member

I mean Unix v windows new-line

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
Copy link
Member

@jkowall I ran dos2unix on the file and it fixed the line endings.

@albertteoh is this PR still needed, or does the one you made already covers this?

@albertteoh
Copy link
Contributor

@albertteoh is this PR still needed, or does the one you made already covers this?

The PR I made should cover this PR.

@yurishkuro yurishkuro closed this Jun 5, 2023
@jkowall jkowall deleted the spm-processor-changes branch September 17, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants