-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected the docs per the changes from the spanmetrics processor to spanmetrics connector #632
Conversation
…the spanmetrics connector Signed-off-by: Jonah Kowall <[email protected]>
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like all line endings are changed, while the text changes are minor. Please make sure to keep the original line endings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together, Jonah. I've added a comment about the timing of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some breaking changes introduced in the spanmetrics connector. As such, I suggest we address jaegertracing/jaeger#4345 first before we merge this change into documentation.
I am not sure what you mean by line endings? I am also not sure why the full file changed when I only edited a few things. Probably has to do with copying files around. |
I mean Unix v windows new-line |
Signed-off-by: Yuri Shkuro <[email protected]>
@jkowall I ran @albertteoh is this PR still needed, or does the one you made already covers this? |
The PR I made should cover this PR. |
Updating the docs per changes in Otel. I can also add a link to @pavolloffay 's tutorial, might be a good set of examples for users in the doc. Just let me know.