Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of new protoc against Jaeger repos #39

Merged
merged 3 commits into from
Jun 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 40 additions & 7 deletions .github/workflows/build-and-publish.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
name: Docker Image
on:
push:
tags:
- '**'
branches:
- main
branches: [main]
pull_request:
branches: [main]
paths:
- .github/workflows/jaeger-dockerimage.yml
- Dockerfile
- protoc-wrapper
- .github/workflows/jaeger-dockerimage.yml
- Dockerfile
- protoc-wrapper
release:
types: [published]
# allow running release workflow manually
workflow_dispatch:

jobs:
build:
Expand Down Expand Up @@ -56,3 +58,34 @@ jobs:
cache-from: type=gha
cache-to: type=gha,mode=max
platforms: linux/amd64,linux/arm64

# The following steps run only on pull requests and validate
# that the new image can run successfully in Jaeger repos.
# We do not check if the generated files would be different there,
# only that the build does not fail.

- name: Checkout Jaeger for validation
if: github.event_name == 'pull_request'
uses: actions/checkout@v4
with:
repository: jaegertracing/jaeger
submodules: recursive
path: jaeger

- name: Build Proto in Jaeger
if: github.event_name == 'pull_request'
working-directory: jaeger
run: make proto JAEGER_DOCKER_PROTOBUF=protobuf

- name: Checkout jaeger-idl for validation
if: github.event_name == 'pull_request'
uses: actions/checkout@v4
with:
repository: jaegertracing/jaeger-idl
submodules: recursive
path: jaeger-idl

- name: Build Proto in jaeger-idl
if: github.event_name == 'pull_request'
working-directory: jaeger-idl
run: make proto PROTOC_IMAGE=protobuf