Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically tag triage for new bug reports #4

Merged
merged 1 commit into from
May 20, 2024

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented May 20, 2024

Modify the issue template to add trage tag in addition to the bug tag.

Description of the changes

Add the triage tag in addition to the bug tag

How was this change tested?

Not tested

Checklist

Modify the issue template to add trage tag in addition to the bug tag. 

Signed-off-by: Jonah Kowall <[email protected]>
@yurishkuro
Copy link
Member

I don't think this is the best approach. Templates are "suggestions", you can see their attributes passed in the URL which you can just delete (I often do that myself since I don't need / want to populate the complete bug report). To ensure that the label is always added, I would rather do it via GH actions, e.g. https://docs.github.com/en/actions/managing-issues-and-pull-requests/adding-labels-to-issues (even more powerful manipulation capabilities are available via actions/github-script)

NB: https://github.com/github/command this allows executing workflows based on "commands" added to the comments. Not immediately needed, but could be a nice way of transitioning issues between triaging state diagram. We can technically just change the labels manually, but doing so is invisible to people subscribed to the issue, whereas comments do send notifications.

NB2: before applying a triage label I would like to define a state machine diagram & procedure. We probably need more than one label.

NB3: I suspect the workflows can only be added at the repo level, not for the whole org.

@jkowall
Copy link
Contributor Author

jkowall commented May 20, 2024

We are already using this method to tag as bug so this was merely adding another tag in the automation. Adding a GH action seems like overkill when we just want to add the tag when the issue is opened.

@yurishkuro
Copy link
Member

The difference, to me, is that bug tag is fyi only, nothing depends on it. But triage tag is part of the workflow - if it's not added the issues can fall through the cracks. And if we don't have a workflow implemented, there is no value in the triage tag anyway.

@jkowall
Copy link
Contributor Author

jkowall commented May 20, 2024

The purpose of the triage tag is to find the issues needing triage. Once the traige is done the tag is removed.

@yurishkuro yurishkuro merged commit 65ca63d into jaegertracing:main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants