Skip to content

Commit

Permalink
Fix issue for total row (nagarajanchinnasamy#63)
Browse files Browse the repository at this point in the history
* Fix issue for total trow

* Update readme with script
  • Loading branch information
Lramelot authored and nagarajanchinnasamy committed Oct 25, 2018
1 parent 29bf772 commit 74fd41a
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Please refer to [Wiki Pages](https://github.com/nagarajanchinnasamy/subtotal/wik

To install the development dependencies, just run `npm install`, which will create a `node_modules` directory with the files required to run the [Gulp](http://gulpjs.com/) build system.

After modifying any of the `.coffee` files at the top of the repo, you can compile/minify the files into the `dist` directory by running `node_modules/gulp/bin/gulp.js`
After modifying any of the `.coffee` files at the top of the repo, you can compile/minify the files into the `dist` directory by running `npm run build`

Once that's done, you can point your browser to `tests/index.html` to run the [Jasmine](http://jasmine.github.io/) test suite. You can view the [current test results here](http://nagarajanchinnasamy.com/subtotal/tests).

Expand Down
3 changes: 1 addition & 2 deletions dist/subtotal.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/subtotal.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/subtotal.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/subtotal.min.js.map

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,19 @@
"dependencies": {
"pivottable": ">=2.7.0"
},
"scripts": {
"build": "gulp"
},
"devDependencies": {
"gulp": "^3.8.10",
"gulp": "^3.9.1",
"gulp-bump": "^2.5.1",
"gulp-clean-css": "^3.9.0",
"gulp-coffee": "^2.2.0",
"gulp-concat": "^2.4.2",
"gulp-debug": "^3.1.0",
"gulp-filter": "^4.0.0",
"gulp-git": "^1.12.0",
"gulp-clean-css": "^3.9.0",
"gulp-minify-css": "^1.2.4",
"gulp-rename": "^1.2.0",
"gulp-serve": "^1.2.0",
"gulp-sourcemaps": "^1.2.8",
Expand Down
2 changes: 1 addition & 1 deletion subtotal.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ callWithJQuery ($) ->
"data-row": "row#{rh.row}"
"data-rowcol": "col#{rh.col}"
"data-rownode": rh.node,
getTableEventHandlers val, rh.key, [], rowAttrs, colAttrs, opts
getTableEventHandlers val, rh.key, [], rowAttrs, colAttrs, opts
tr.appendChild td

buildColTotalsHeader = (rowAttrs, colAttrs) ->
Expand Down

0 comments on commit 74fd41a

Please sign in to comment.