Added unit tests. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
unit-tests
branch
3 times, most recently
from
209ee0c to
462aae1
Compare
out/.gitkeep
Outdated
There was a problem hiding this comment.
Instead of adding this to VCS maybe we could just dynamically create it in the test?
There was a problem hiding this comment.
That would mean including it in .gitignore to avoid others checking it in.
|
@jacobtomlinson Updated. |
jacobtomlinson
approved these changes
Mar 11, 2024
|
Thanks @dblock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking of adding a feature, but first unit tests. A bit easier to test/evolve than the integration test with GHA since there will be a bunch of scenarios. I don't feel strongly about it though, so feel free to tell me to add other integration-like tests instead.
Passing in https://github.com/dblock/gha-find-replace/actions.