Skip to content

Commit

Permalink
feat: enable embroider's staticComponents option
Browse files Browse the repository at this point in the history
Had to downgrade @ember/test-helpers to 2.7.x
emberjs/ember-test-helpers#1220
  • Loading branch information
jacobq committed May 18, 2022
1 parent 46aa2c6 commit 3ea2bf3
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 14 deletions.
2 changes: 1 addition & 1 deletion ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = function (defaults) {
staticAddonTrees: true,
staticHelpers: true,
staticModifiers: true,
// staticComponents: true, <-- doesn't work yet
staticComponents: true, // See https://github.com/emberjs/ember-test-helpers/issues/1220
// splitAtRoutes: ['route.name'], // can also be a RegExp
packagerOptions: {
webpackConfig: {
Expand Down
19 changes: 7 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"devDependencies": {
"@ember/optional-features": "^2.0.0",
"@ember/test-helpers": "^2.8.0",
"@ember/test-helpers": "~2.7.0",
"@embroider/compat": "^1.6.0",
"@embroider/core": "^1.6.0",
"@embroider/webpack": "^1.6.0",
Expand Down

0 comments on commit 3ea2bf3

Please sign in to comment.