fix: timezone issue with ISO dates #1614
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the date is in YYYY-MM-DD format, which is the default for the Obsidian 'date' file property, it will be interpreted as UTC midnight which will mean it renders incorrectly as the previous day when passed to 'getLocaleDateString'. Adding a time makes it interpret as midnight in the local timezone instead so it will render as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the date is in YYYY-MM-DD format, which is the default for the Obsidian 'date' file property, it will be interpreted as UTC midnight rather than local time midnight. If the local timezone is at a negative GMT offset, this means it will render incorrectly as the previous day when passed to 'getLocaleDateString'.
Adding a time to the input string before passing to the
Date()constructor makes it interpret the string as midnight in the local timezone instead so it will render as expected.Context: