Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails on IOS Chrome #96

Open
istvanmakary opened this issue Jun 5, 2019 · 0 comments
Open

Fails on IOS Chrome #96

istvanmakary opened this issue Jun 5, 2019 · 0 comments

Comments

@istvanmakary
Copy link

istvanmakary commented Jun 5, 2019 •
edited
Loading

Using IOS Google Chrome 75.0.3770.70 client.isMobile() test returns false. The navigator's user agent simply doesn't contains the iPhone keyword, I guess this is why it's failing. It would be nice to check navigator.platform in this case, because it returns iPhone.
istvanmakary added a commit to istvanmakary/clientjs that referenced this issue Jun 6, 2019
@istvanmakary
Update client.js
4f67190 
Fix issue described here: jackspirou#96.
istvanmakary added a commit to istvanmakary/clientjs that referenced this issue Jun 6, 2019
@istvanmakary
Update client.js
64a338c 
Fix issue described here: jackspirou#96.
@istvanmakary istvanmakary mentioned this issue Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@istvanmakary