-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.9.24 #1228
Version 0.9.24 #1228
Conversation
Reviewer's Guide by SourceryThis pull request updates the project to version 0.9.24, focusing on improvements to Rule Md031 and container-based indenting. The changes include adding new test cases, fixing issues with nested containers and list starts, and introducing a new helper class for tracking line-to-container token relationships. Class diagram for the new helper class in version 0.9.24classDiagram
class LineToContainerTracker {
+trackLineToContainer(line: String, containerTokens: List<Token>)
+getContainerIndentation(line: String): int
+resetTracker()
}
class Token {
<<interface>>
+getType(): String
+getValue(): String
}
LineToContainerTracker --> Token : uses
note for LineToContainerTracker "A new helper class to assist in tracking line to container tokens for container-based indenting."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jackdewinter - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This has meant introducing a new helper class to assist in the tracking | ||
of a given line to the container tokens used to provide container-based | ||
indenting for that line. This is very important for Rule Md031, and | ||
has already proveded to be useful in a partial rewrite of some of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Fix typo: 'proveded' should be 'proved'
- [Issue 1166](https://github.com/jackdewinter/pymarkdown/issues/1166) | ||
- [Issue 1167](https://github.com/jackdewinter/pymarkdown/issues/1167) | ||
- [Issue 1168](https://github.com/jackdewinter/pymarkdown/issues/1168) | ||
- fixed issue with more deeply nested | ||
- fixed issue with more deeply nested containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider providing more specific details for each issue
It might be helpful for users to understand what specific problems were addressed in issues 1166, 1167, and 1168. If they're closely related, you could explain the relationship.
- [Issue 1166](https://github.com/jackdewinter/pymarkdown/issues/1166) | |
- [Issue 1167](https://github.com/jackdewinter/pymarkdown/issues/1167) | |
- [Issue 1168](https://github.com/jackdewinter/pymarkdown/issues/1168) | |
- fixed issue with more deeply nested | |
- fixed issue with more deeply nested containers | |
[Issue 1166](https://github.com/jackdewinter/pymarkdown/issues/1166) | |
- Fixed handling of list starts when grouped on the same line | |
[Issue 1167](https://github.com/jackdewinter/pymarkdown/issues/1167) | |
- Improved parsing of nested list structures | |
[Issue 1168](https://github.com/jackdewinter/pymarkdown/issues/1168) | |
- Resolved issues with deeply nested containers in complex layouts |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 191 191
Lines 21037 21037
Branches 2683 2683
=========================================
Hits 21037 21037 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Release version 0.9.24, focusing on improvements for Rule Md031 and nested container handling. Introduce a new helper class for container-based indenting, fix list start issues, and address deeply nested container problems. Update the changelog and increment the library version.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Chores: