Expose ResultReader.Err() to allow row iteration to check for errors #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2020
|
@eh-steve I think this isn't needed anymore. |
|
I think the underlying issues have been resolved. Feel free to reopen if that's not the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR and the accompanying jackc/pgconn#58 address a problem where
ResultReadererrors due to statement cache errors would be swallowed during row iteration (sincer.NextRow()would return false immediately, since its command is concluded), making a query apparently execute with no errors, but providing no rows.This might be closed in favour of #865, which addresses the same problem differently