Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to set nonumber for popup windows #385

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

tvntvn13
Copy link
Contributor

@tvntvn13 tvntvn13 commented Feb 4, 2024

Addresses #234

  • add 'show_line_numbers = true' to default config
  • add check in code_edits.lua before setting the line numbers for the window
  • setting 'show_line_numbers = false' will disable the line numbers

when setting show_line_numbers = false, it would be advisable to also set the popup_window.win_options.foldcolumn = "0", to get clean experience, but I left that option for the users.

@jackMort jackMort merged commit ff458cb into jackMort:main Feb 25, 2024
1 check passed
Wezea pushed a commit to Wezea/ChatGPT.nvim that referenced this pull request Apr 20, 2024
qaptoR pushed a commit to qaptoR-nvim/ChatGPT.nvim that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants