-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#479 Added dryRun #485
Merged
Merged
#479 Added dryRun #485
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d09c238
#479 Added dryRun
yaseno2186 5b0b946
#479 Changed to work on dryRun branch
yaseno2186 d7c538d
#479 cleaned release.yml
yaseno2186 29e8176
#479 created a checkbox or the dry run release.yml
yaseno2186 a62d438
#479 bug fixed removed a needs
yaseno2186 f005487
#479 bug fix Unexpected value 'true'
yaseno2186 f27a066
#479 cleaned dryRun code
yaseno2186 13c8f9a
#479 adjusted for master branch
yaseno2186 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,34 +4,42 @@ name: Release | |
on: | ||
workflow_dispatch: | ||
inputs: | ||
java_version: | ||
description: Java version to use | ||
type: string | ||
required: false | ||
default: 17 | ||
branch: | ||
description: "The branch to checkout when cutting the release." | ||
required: true | ||
default: "master" | ||
releaseVersion: | ||
description: "Default version to use when preparing a release." | ||
description: 'The release version' | ||
required: true | ||
default: "X.Y.Z" | ||
developmentVersion: | ||
description: "Default version to use for new local working copy." | ||
description: 'The development version' | ||
required: true | ||
dryRun: | ||
description: 'Whether to perform a dry run' | ||
required: true | ||
default: "X.Y.Z-SNAPSHOT" | ||
default: 'false' | ||
type: boolean | ||
|
||
jobs: | ||
dry-run: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This adds a dryRun before the actual release build, this is not intented. |
||
if: ${{ github.event.inputs.dryRun }} | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Perform Dry Run | ||
run: | | ||
mvn release:prepare release:perform \ | ||
-ntp \ | ||
--batch-mode \ | ||
-DreleaseVersion=${{ inputs.releaseVersion }} \ | ||
-DdevelopmentVersion=${{ inputs.developmentVersion }} \ | ||
-DdryRun=${{ inputs.dryRun }} | ||
build: | ||
uses: jqassistant-tooling/jqassistant-github-actions/.github/workflows/release.yml@main | ||
needs: dry-run | ||
uses: jqassistant-tooling/jqassistant-github-actions/.github/workflows/release.yml@dryrun | ||
with: | ||
branch: ${{ github.event.inputs.branch }} | ||
releaseVersion: ${{ github.event.inputs.releaseVersion }} | ||
developmentVersion: ${{ github.event.inputs.developmentVersion }} | ||
dryRun: ${{ github.event.inputs.dryRun }} | ||
secrets: | ||
ossrh_username: ${{ secrets.OSSRH_USERNAME }} | ||
ossrh_password: ${{ secrets.OSSRH_PASSWORD }} | ||
ossrh_signing_key: ${{ secrets.OSSRH_SIGNING_KEY }} | ||
ossrh_signing_password: ${{ secrets.OSSRH_SIGNING_PASSWORD }} | ||
sonar_token: ${{ secrets.SONAR_TOKEN }} | ||
sonar_token: ${{ secrets.SONAR_TOKEN }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the Java version parameter gone?