Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#479 Added dryRun #485

Merged
merged 8 commits into from
Jul 17, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,34 +4,42 @@ name: Release
on:
workflow_dispatch:
inputs:
java_version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the Java version parameter gone?

description: Java version to use
type: string
required: false
default: 17
branch:
description: "The branch to checkout when cutting the release."
required: true
default: "master"
releaseVersion:
description: "Default version to use when preparing a release."
description: 'The release version'
required: true
default: "X.Y.Z"
developmentVersion:
description: "Default version to use for new local working copy."
description: 'The development version'
required: true
dryRun:
description: 'Whether to perform a dry run'
required: true
default: "X.Y.Z-SNAPSHOT"
default: 'false'
type: boolean

jobs:
dry-run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a dryRun before the actual release build, this is not intented.

if: ${{ github.event.inputs.dryRun }}
runs-on: ubuntu-latest
steps:
- name: Perform Dry Run
run: |
mvn release:prepare release:perform \
-ntp \
--batch-mode \
-DreleaseVersion=${{ inputs.releaseVersion }} \
-DdevelopmentVersion=${{ inputs.developmentVersion }} \
-DdryRun=${{ inputs.dryRun }}
build:
uses: jqassistant-tooling/jqassistant-github-actions/.github/workflows/release.yml@main
needs: dry-run
uses: jqassistant-tooling/jqassistant-github-actions/.github/workflows/release.yml@dryrun
with:
branch: ${{ github.event.inputs.branch }}
releaseVersion: ${{ github.event.inputs.releaseVersion }}
developmentVersion: ${{ github.event.inputs.developmentVersion }}
dryRun: ${{ github.event.inputs.dryRun }}
secrets:
ossrh_username: ${{ secrets.OSSRH_USERNAME }}
ossrh_password: ${{ secrets.OSSRH_PASSWORD }}
ossrh_signing_key: ${{ secrets.OSSRH_SIGNING_KEY }}
ossrh_signing_password: ${{ secrets.OSSRH_SIGNING_PASSWORD }}
sonar_token: ${{ secrets.SONAR_TOKEN }}
sonar_token: ${{ secrets.SONAR_TOKEN }}
Loading