Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

478 jqa tries to load rules from jqa report file #482

Merged
merged 9 commits into from
Jul 17, 2024
Merged

478 jqa tries to load rules from jqa report file #482

merged 9 commits into from
Jul 17, 2024

Conversation

yaseno2186
Copy link
Contributor

Moved XMLHelper to Core shared
Added 3 tests
Added adjusted XmlRuleParserPlugin to read only rules
Adjusted Import order

@yaseno2186
#478 Bug fix
f48144f 
Added in XmlRuleParserPlugin only to accept xml rule files
Moved XmlHelper from core rule to shared
Added test in XmlRuleParserPluginTest
Adjusted import in order
@yaseno2186
#478 Bug fix
466c4df 
Added 1 test in XmlRuleParserPluginTest
Cleaned code
@yaseno2186
#478 Bug fix
31dd153 
Adjusted import list in XmlRuleParserPluginTest
@yaseno2186
Merge branch 'refs/heads/master' into 478-jqa-tries-to-load-rules-fro…
8cf518f 
…m-jqa-report-file

# Conflicts:
#	core/rule/src/test/java/com/buschmais/jqassistant/core/rule/api/model/XmlRuleParserPluginTest.java
@yaseno2186
#478 Bug fix
846818f
@yaseno2186 yaseno2186 requested a review from DirkMahler July 15, 2024 13:25
@yaseno2186 yaseno2186 requested a review from DirkMahler July 16, 2024 09:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
24.1% Coverage on New Code (required ≥ 80%)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

DirkMahler
DirkMahler approved these changes Jul 17, 2024
View reviewed changes
...ule/src/test/java/com/buschmais/jqassistant/core/rule/api/model/XmlRuleParserPluginTest.java
@@ -1,12 +1,16 @@
package com.buschmais.jqassistant.core.rule.api.model;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat the class with the jQA settings

@DirkMahler DirkMahler merged commit 6a22c6f into master Jul 17, 2024
5 of 6 checks passed
@DirkMahler DirkMahler deleted the 478-jqa-tries-to-load-rules-from-jqa-report-file branch July 17, 2024 08:39
@yaseno2186 yaseno2186 linked an issue Jul 18, 2024 that may be closed by this pull request
jQA tries to load rules from jQA report file #478
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirkMahler DirkMahler DirkMahler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jQA tries to load rules from jQA report file
2 participants
@yaseno2186 @DirkMahler