Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Neo4j Plugin dir to build directory #657

Closed
StephanPirnbaum opened this issue Oct 2, 2024 · 0 comments
Closed

Default Neo4j Plugin dir to build directory #657

StephanPirnbaum opened this issue Oct 2, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@StephanPirnbaum
Copy link
Contributor

StephanPirnbaum commented Oct 2, 2024

Currently, Neo4j plugins are stored in /tmp/ if not configured otherwise. This causes issues under Windows as deletion of the plugins happens when there is still a lock on the jar files, leading to plugin not being deleted. Furthermore, it happened that during one build, two different /tmp/ plugin dirs were used, with one not being populated previously.

It would be better to use the build directory by default to store the Neo4j plugins and let Maven clean take care of deleting them instead of doing it from jQAssistant.

To avoid errors of copying Neo4j plugins multiple times into the plugin dir, it shoudl be checked if the file already exists:

at org.apache.commons.io.FileUtils.copyFile (FileUtils.java:859)
at org.apache.commons.io.FileUtils.copyFile (FileUtils.java:812)
at org.apache.commons.io.FileUtils.copyFileToDirectory (FileUtils.java:960)
at org.apache.commons.io.FileUtils.copyFileToDirectory (FileUtils.java:931)
at com.buschmais.jqassistant.core.store.impl.EmbeddedGraphStore.resolveNeo4jPlugins (EmbeddedGraphStore.java:98)
at com.buschmais.jqassistant.core.store.impl.EmbeddedGraphStore.configure (EmbeddedGraphStore.java:80)
at com.buschmais.jqassistant.core.store.impl.AbstractGraphStore.start (AbstractGraphStore.java:70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants