#86 updated release-notes.adoc

jQAssistant · Jun 13, 2024 · 87cb103 · 87cb103
1 parent ccfefd0
commit 87cb103
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/plugin/maven/src/main/asciidoc/release-notes.adoc b/plugin/maven/src/main/asciidoc/release-notes.adoc
@@ -3,6 +3,7 @@
 
 == 2.3.0
 
+* Added missing classifier `tests` to test artifacts created by the Maven project scanner
 * Ensure that the property `fileName` is set for `:Maven:Project` nodes that represent local (i.e. scanned) Maven projects
 
 == 1.12.0

diff --git a/...n/java/com/buschmais/jqassistant/plugin/maven3/api/artifact/MavenArtifactCoordinates.java b/...n/java/com/buschmais/jqassistant/plugin/maven3/api/artifact/MavenArtifactCoordinates.java
@@ -7,7 +7,8 @@ public class MavenArtifactCoordinates implements Coordinates {
     /**
      * The artifact type for test jars.
      */
-    public static final String ARTIFACTTYPE_TEST_JAR = "test-jar";
+    public static final String TYPE_TEST_JAR = "test-jar";
+    public static final String CLASSIFIER_TESTS = "tests";
 
     private Artifact artifact;
     private boolean testJar;
@@ -29,12 +30,12 @@ public String getName() {
 
     @Override
     public String getClassifier() {
-        return artifact.getClassifier();
+        return testJar ? CLASSIFIER_TESTS : artifact.getClassifier();
     }
 
     @Override
     public String getType() {
-        return testJar ? ARTIFACTTYPE_TEST_JAR : artifact.getType();
+        return testJar ? TYPE_TEST_JAR : artifact.getType();
     }
 
     @Override

diff --git a/...a/com/buschmais/jqassistant/plugin/maven3/impl/scanner/MavenProjectScannerPluginTest.java b/...a/com/buschmais/jqassistant/plugin/maven3/impl/scanner/MavenProjectScannerPluginTest.java
@@ -267,7 +267,7 @@ private void scanAndVerify(Map<String, Object> properties, boolean expectedDepen
         verify(projectDescriptor).setEffectiveModel(effectiveModelDescriptor);
         verify(artifactCache).get(argThat(fqn -> fqn.contains(":jar:")), any());
         verify(store).addDescriptorType(mainArtifactDescriptor, JavaClassesDirectoryDescriptor.class);
-        verify(artifactCache).get(argThat(fqn -> fqn.contains(":test-jar:")), any());
+        verify(artifactCache).get(argThat(fqn -> fqn.contains(":test-jar:tests:")), any());
         verify(store).addDescriptorType(testArtifactDescriptor, JavaClassesDirectoryDescriptor.class);
 
         verify(dependencyGraphBuilder).buildDependencyGraph(any(ProjectBuildingRequest.class), eq(null));