Implement functionality present on String and SmallVec #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To clarify: this is for methods which are present on both, not things
unique to one or the other. It wouldn't make sense to support set_len
like SmallVec::set_len, or as_mut_vec like String::as_mut_vec.
This PR:
- removes default size = [u8; 8] to match behavior of `SmallVec`
- implements many methods available on `SmallVec` but not `SmallString`
- implements `AsMut` without feature gate and without requiring rust
1.20+
- implements `Extend` efficiently with pre-reserved capacity
- re-implements `FromIterator` more simply
- the previous `FromIterator` implementation worked well and was
efficient, but it's possible to achieve the same result without
creating a whole struct implementing Iterator.
- updates `smallvec` crate dependency to achieve full functionality
- implements many more traits which can be implemented
- implements some From implementations more efficiently using direct
byte-for-byte copies rather than `collect()` on an iterator.
Closes jFransham#1.
Closes jFransham#2.
Closes jFransham#3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a large amount of functionality to
SmallString.I've found the library very useful, so I thought this would be a good way to contribute back.
Most methods which make sense from
StringandSmallVecare now implemented onSmallString.This PR:
SmallVecSmallVecbut notSmallStringAsMutwithout feature gate and without requiring rust 1.20+Extendefficiently with pre-reserved capacityFromIteratormore simplyFromIteratorimplementation worked well and was efficient, but it's possible to achieve the same result without creating a whole struct implementing Iterator. The new behavior matchesString::from_iterator.smallveccrate dependency to achieve full functionalitycollect()on an iterator.Fixes #1, supersedes #2, #3.