Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namelist delimiter proposal #94

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Conversation

marshallward
Copy link
Contributor

This patch includes a proposal to require delimiters for characters
arrays in namelist output.

This patch includes a proposal to require delimiters for characters
arrays in namelist output.
@certik
Copy link
Member

certik commented Jan 3, 2020

@marshallward thanks for the PR. Can you comment on #122 and (hopefully) list it among your top 5?

Copy link
Member

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High quality proposal. Thanks for submitting it. I am going to merge and upload now.

@zjibben
Copy link
Member

zjibben commented Feb 24, 2020

This is a very nice proposal, thanks! I think one thing to improve it more would be a code example showing the problem.

@certik certik merged commit 473c42a into j3-fortran:master Feb 24, 2020
@certik
Copy link
Member

certik commented Feb 24, 2020

@marshallward can you send us an example how this would be used? Ideally as a PR to the already merged file. This would greatly help us when advocating for the proposal. It's a little bit unclear without an example.

After you send it, we will upload it and discuss it at the committee.

Thanks!

@marshallward
Copy link
Contributor Author

Sure, I will send a change in tomorrow morning. Thanks very much for the corrections and reformatting!

@certik
Copy link
Member

certik commented Feb 24, 2020

@marshallward thanks! Please ping me when you do so.

@marshallward
Copy link
Contributor Author

@certik @zjibben I've submitted an update here: #154

This includes an example section describing how to reproduce the current issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants