-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namelist delimiter proposal #94
Conversation
This patch includes a proposal to require delimiters for characters arrays in namelist output.
@marshallward thanks for the PR. Can you comment on #122 and (hopefully) list it among your top 5? |
Co-Authored-By: Zach Jibben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High quality proposal. Thanks for submitting it. I am going to merge and upload now.
This is a very nice proposal, thanks! I think one thing to improve it more would be a code example showing the problem. |
@marshallward can you send us an example how this would be used? Ideally as a PR to the already merged file. This would greatly help us when advocating for the proposal. It's a little bit unclear without an example. After you send it, we will upload it and discuss it at the committee. Thanks! |
Sure, I will send a change in tomorrow morning. Thanks very much for the corrections and reformatting! |
@marshallward thanks! Please ping me when you do so. |
This patch includes a proposal to require delimiters for characters
arrays in namelist output.