Allow spaces in Xcode targets #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brunobowden
commented
Nov 6, 2015
brunobowden
commented
- Allow spaces in Xcode targets
- Continue to reject spaces for command line arguments
- Additionally reject arguments that are only whitespace
- For watchOS, change unsupported exception to warning for development
- Allow spaces in Xcode targets - Continue to reject spaces for command line arguments - Additionally reject arguments that are only whitespace - For watchOS, change unsupported exception to warning for development
|
Turns out that many Xcode targets have spaces by default, particularly the watch app and extensions |
|
As a naked boolean, methods like appendNoWhitespaceArgs and appendWhitespaceArgs (and similarly named verify... methods) might be more readable. Your call, LGTM either way. |
|
I tried both ways and slightly preferred this. Though I see points in both directions. |
brunobowden
added a commit
that referenced
this pull request
Nov 9, 2015
Allow spaces in Xcode targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.