Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

j2objcAssemble{Debug|Release} depends on j2objcXcode #532

Merged
merged 1 commit into from
Oct 23, 2015
Merged

j2objcAssemble{Debug|Release} depends on j2objcXcode #532

merged 1 commit into from
Oct 23, 2015

Conversation

brunobowden
Copy link
Contributor

  • j2objcAssemble nolonger depends directly on j2objcXcode

@brunobowden
Copy link
Contributor Author

@advayDev1 - this isn't strictly necessary but it feels like a better place for j2objcXcode. Please share your feedback on this.

@advayDev1
Copy link
Contributor

If pod install does not rely on the libraries existing or anything like that, LGTM. While I know the XcodeTask does not have those generated files as input files, I do not know the internals of pod install.

@brunobowden
Copy link
Contributor Author

I tested the pod install for two podspecs with dangling references and it worked just fine. I've add a comment to the task and will merge now.

brunobowden added a commit that referenced this pull request Oct 23, 2015
@brunobowden
Merge pull request #532 from brunobowden/improve
d590940 
j2objcAssemble{Debug|Release} depends on j2objcXcode
@brunobowden brunobowden merged commit d590940 into j2objc-contrib:master Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobowden @advayDev1