Minimum OS versions, fixed iOS & OS X builds #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@advayDev1 - This was the main blocker I had for the 0.5 release. I will be following along with a more extensive system test for it. |
| @@ -638,7 +640,8 @@ class J2objcConfig { | |||
| * <p/> | |||
| * See https://developer.apple.com/library/ios/documentation/DeveloperTools/Conceptual/cross_development/Configuring/configuring.html#//apple_ref/doc/uid/10000163i-CH1-SW2 | |||
| */ | |||
| String minWatchosVersion = '1.0' | |||
| // Matches the oldest version supported in Xcode 7 | |||
| String minVersionWatchos = '1.0' | |||
There was a problem hiding this comment.
i'm intrigued as to how this is working right now. the watch version is not used in the native build, only in the podspec. does native build not need to know about watch os?
There was a problem hiding this comment.
As the title notes, this gets iOS and OS X working... I haven't got watchOS working yet. This is a necessary step, so I wanted to include it. I can comment it out for now if you want.
There was a problem hiding this comment.
nah, keep it in. please do note in the commit that watchOS does not work though.
|
lgtm with comments |
- Minimum OS versions for iOS, OS X and watchOS - xcodeTargets => xcodeTargetsIos, xcodeTargetsOsx & xcodeTargetsWatchos - Extensive refactoring of Podfile updating logic - Extensive unit tests for all the forgoing changes - Fixes j2objc-contrib#520 TODO: get watchOS build working
brunobowden
added a commit
that referenced
this pull request
Oct 21, 2015
Minimum OS versions, fixed iOS & OS X builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: get watchOS build working