Support Xcode 7: Refactor of native compilation to support separate ios vs. osx librar… #483
Conversation
|
@brunobowden - you might as well ptal. good news: xcode 7 and unit-tests-on-osx seem to be working fine. once we upgrade to j2objc 0.9.8.2.1 - xcode 6 no longer works at all (i think this is an acceptable tradeoff, and i do not believe we should do any further coding to make it work with xcode 6 and 7). i have a mind just to disable the failing unit test - we haven't been able to figure it out over the last 2 months, and xcode 7 is more important. thoughts? |
advayDev1
changed the title
Refactor of native compilation to support separate ios vs. osx libraries. Issue j2objc-contrib#466
|
I've decided simply to @ignore that one test and get on with things. It isn't a regression, and we now have system tests to really exercise our dependency code anyway. |
| @@ -15,23 +15,27 @@ | |||
| */ | |||
|
|
|||
| package com.github.j2objccontrib.j2objcgradle | |||
|
|
|||
There was a problem hiding this comment.
We have a blank line gap in all other files. I've seen this happen before for your PRs... is the editor doing something automatically?
There was a problem hiding this comment.
yeah IntelliJ being annoying
| mkdir localJ2objcDist | ||
| mkdir common | ||
|
|
||
| # Fail if any command fails | ||
| set -e | ||
| set -ev |
There was a problem hiding this comment.
Another good flag to use it -u, which treats unset variables as an error when substituting.
There was a problem hiding this comment.
good to know, but in this case i think we're fine as there are no conditional settings
|
LGTM - this code already looks much better organized compared to what it was before. I'll experiment with this tomorrow. |
|
cool, as soon as i get a green travis with these changes i will submit. thanks! |
Support Xcode 7: Refactor of native compilation to support separate ios vs. osx librar…
…ies.
Issue #466