Wildcard prefix matching #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
| String root = s.substring(0, s.length() - 2).replace(".", "\\."); | ||
| return String.format('^(%s|%s\\..*)$', root, root); | ||
| } | ||
| return String.format('^%s$', s.replace(".", "\\.").replace("\\*", ".*")); |
There was a problem hiding this comment.
use Pattern.quote(s) as the format argument
There was a problem hiding this comment.
I deliberately want this to match the logic within J2ObjC's code. Some I'm minimizing changes to make it easier to compare in the future.
|
lgtm with comments |
Fixes j2objc-contrib#430 Example: prefixes.properties: com.example.dir.*=Wildcard Test File: com/example/dir/subdir/Test.java Test Name: WildcardTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430
Example: