Build external Java libs into standalone native libs. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advayDev1
force-pushed
the
allLocal
branch
2 times, most recently
from
9f9556d
to
c2a3b66
Compare
|
ping @brunobowden |
| @@ -26,7 +26,7 @@ import org.gradle.api.artifacts.SelfResolvingDependency | |||
|
|
|||
| /** | |||
| * Converts `[test]compile` dependencies to their | |||
| * `j2objcTranslation` and/or `j2objcLinkage` equivalents, depending on the type | |||
| * `j2objcTranslationClosure` and/or `j2objcLinkage` equivalents, depending on the type | |||
There was a problem hiding this comment.
Improve explanation:
* Converts `[test]compile` dependencies to one of the following (or their equivalent):
* j2objcLinkage - EXPLANATION HERE
* j2objcTranslationClosure - EXPLANATION HERE
There was a problem hiding this comment.
Done, but for DependencyConverter I just detailed how compile and testCompile get converted.
The definitions of j2objcLinkage, etc. are now in DependencyResolver's javadoc.
|
LGTM |
Rename the old `j2objcTranslation` to `j2objcTranslationClosure` Add a new dependency type `j2objcTranslation` that allows you to convert an entire source jar into a standalone library as a separate Gradle project. You then depend on that project instead of the external library when you want to use the functionality elsewhere. This causes the external library to be translated and compiled only once, and not partially and duplicatively as with --build-closure. Fixes j2objc-contrib#429; fixes j2objc-contrib#419 TESTED=yes
advayDev1
added a commit
that referenced
this pull request
Aug 28, 2015
Build external Java libs into standalone native libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the old
j2objcTranslationtoj2objcTranslationClosureAdd a new dependency type
j2objcTranslationthat allows you toconvert an entire source jar into a standalone library as a separate Gradle project.
You then depend on that project instead of the external library when
you want to use the functionality elsewhere.
This causes the external library to be translated and compiled only once,
and not partially and duplicatively as with --build-closure.
Fixes #429; fixes #419
TESTED=yes