Detect Windows and Linux and warn if not supported #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
|
I guess this causes unit-tests to fail: |
brunobowden
force-pushed
the
update
branch
3 times, most recently
from
0f0b65b
to
cdcdb67
Compare
|
@advayDev1 - it was quite a bit of work but there's now a Utils.fakeOSName static string that can be set for testing. I was tempted to add some tests that skip using fakeOSName... but I think that's likely best covered by doing some actual project builds. |
|
I've improved a number of the unsupported error messages, indicating which task is unsupported. This also pushes us over 100 unit tests... we're now at 104 of them. |
| List<String> windowsOnlyArgs = new ArrayList<String>() | ||
| if (Utils.isWindows()) { | ||
| List<String> nonMacOSXArgs = new ArrayList<String>() | ||
| if (!Utils.isMacOSX()) { | ||
| cycleFinderExec = 'java' |
There was a problem hiding this comment.
is the java binary needed on Linux (as opposed to just windows)?
the shell script should be fine no?
There was a problem hiding this comment.
'java' only used on Windows
- Error on tasks when Mac OS X is required - Corrected link to the FAQ - FAQ now also mentions Linux alongside Windows - Fake OS name to unit test for Mac and nonMac systems - inTestMustFakeOS property to ensure hermetic tests Testing: - Mac and nonMac command lines - Exception thrown when attempting unsupported tasks (j2objcTest, j2objcPackLibraries and j2objcXcode)
|
lgtm |
brunobowden
added a commit
that referenced
this pull request
Aug 24, 2015
Detect Windows and Linux and warn if not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
(j2objcTest, j2objcPackLibraries and j2objcXcode)