Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

Added EnvironmentVariable annotation and processor. #9

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

gscho
Copy link

@gscho gscho commented Oct 13, 2017

Hi!

I liked the simplicity offered by this library but I also have the need for environment variable injection because we use them extensively in our Docker images.

Wondering if there's any interest in adding this functionality.

Greg

@fmbenhassine
Copy link
Member

Hi!

Fantastic 👍 Indeed, support for environment variables is missing.
Your addition is welcome. Nothing to say about production/test code, that's perfect.

Best regards,
Mahmoud

@fmbenhassine fmbenhassine merged commit de3806c into j-easy:master Oct 13, 2017
@fmbenhassine fmbenhassine added this to the 2.1.0 milestone Oct 13, 2017
@fmbenhassine
Copy link
Member

@gscho I added you to the contributors list and updated the wiki.

I've also deployed version 2.1.0-SNAPSHOT to maven central repo with your changes.

I'll include this feature in the next release. Keep tuned 😉

@gscho
Copy link
Author

gscho commented Oct 13, 2017

Awesome thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants