fix: log errors

izatop · Sep 14, 2021 · 0bc07db · 0bc07db
1 parent 67f7b14
commit 0bc07db
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/util/src/Logger/Logger.ts b/packages/util/src/Logger/Logger.ts
@@ -134,15 +134,17 @@ export class Logger {
             log.args = [];
             for (const arg of args) {
                 if (isInstanceOf(arg, Error)) {
-                    const error: Record<any, any> = {error: {message: arg.message, stack: arg.stack}};
+                    const error: Record<any, any> = {message: arg.message, stack: arg.stack};
                     if (isLogable(arg)) {
                         const logValue = arg.getLogValue();
                         if (isDefined(logValue)) {
                             error.extra = arg.getLogValue();
                         }
                     }
 
-                    log.args.push(error);
+                    const {constructor: {name}} = arg;
+
+                    log.args.push({error: {name, ...error}});
 
                     continue;
                 }

diff --git a/packages/util/test/src/logger/Logger.test.ts b/packages/util/test/src/logger/Logger.test.ts
@@ -42,12 +42,14 @@ describe("Logger", () => {
     });
 
     test("should log logable error", () => {
-        const value = {test: "value"};
+        const extra = {test: "value"};
         const logger = new Logger("Test");
-        const error = new AssertionError("Error", {value});
+        const error = new AssertionError("Error", extra);
+        error.stack = "Error stack";
         logger.error("Error", error);
+
+        const {message, stack, constructor: {name}} = error;
         const {args = []} = logs.pop() ?? {args: []};
-        expect(args.pop()).toEqual({value});
-        expect(args.pop()).toBe(error.stack);
+        expect(args.pop()).toEqual({error: {name, message, stack, extra}});
     });
 });