Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pack.json #1

Merged
merged 1 commit into from Aug 16, 2020
Merged

Update pack.json #1

merged 1 commit into from Aug 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 16, 2020

Added setting-groups and profiles for all NNEDI3 upscalers from 16 to 256 neurons. With ssim-downscaler for downscaling and krig-bilateral for chroma upscaling.

Added `setting-groups` and `profiles` for all NNEDI3 upscalers from 16 to 256 neurons. With `ssim-downscaler` for downscaling and `krig-bilateral` for chroma upscaling.
@iwalton3
Copy link
Owner

iwalton3 commented Aug 16, 2020

What would you say the reasonable options are? I can leave all of the options in the pack, but I'd only prefer to add menu entries for items that would be reasonable to use by default. (Currently my menu system doesn't handle scrolling...)

The nnedi hooks referenced are from here, right? https://github.com/bjin/mpv-prescalers/tree/master
I also need to bundle those.

@ghost
Copy link
Author

ghost commented Aug 16, 2020

I'd say up to 64 is absolutely reasonable. Maybe 128 is okay too in some rare cases but 256 just seems to be placebo for me. I just added all for completeness. Maybe creating another menu entry / directory for Anime4K and NNEDI3 or all shaders with multiple options to select from would be a nice idea to keep it tidy, i.e. Video Playback Profiles - Anime4K - all shaders and Video Playback Profiles - NNEDI3 - all shaders.

@iwalton3
Copy link
Owner

I'll probably consider that in the future. For now I'll add 64 and 128 to the menu.

@iwalton3 iwalton3 merged commit 628999c into iwalton3:master Aug 16, 2020
iwalton3 added a commit that referenced this pull request Aug 16, 2020
@iwalton3
Copy link
Owner

Looks good! Changes are integrated and working.

@ghost ghost deleted the patch-1 branch August 18, 2020 01:09
@ghost ghost restored the patch-1 branch August 18, 2020 01:10
@ghost ghost deleted the patch-1 branch August 18, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant