-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added -lan flag #95
base: develop
Are you sure you want to change the base?
Conversation
- intended for offline/lan gaming - lan flag disables node system
missing documentation of this flag in README.md |
This new flag seems entirely equivalent to On the basis that this feature already exists, I think this PR does not warrant merging? |
Alternatively we could change |
Looking at your implementation, everywhere where you use your flag you could also just use SVLanOnly - if (Dedicated::IsEnabled() && Dedicated::SVLanOnly.get<bool>()) return;
+ if (Network::SVLanOnly.get<bool>()) return; for instance? |
Sure, that’s fine. My reason for creating a new flag was mostly due to naming and consistency with other clients. As of right now the only purpose of the flag is to disable the node system for clients, but I was anticipating it might be used for other things where a separate option for servers and clients would be useful. You are welcome to close this PR and make the single line change mentioned above. Thanks |
What does this PR do?
Adds
-lan
startup flag for offline/lan gaming.How does this PR change IW4x's behaviour?
Disables node system which would print nearly 600 error messages to the console as a result of Sys_SendPacket failing when offline (called from
Node::Entry::sendRequest
).Anything else we should know?
Master server still works should the user regain internet connection.