feat: add poolUsage(s)/assetCount commands #89
Conversation
| @@ -689,5 +698,55 @@ namespace Components | |||
| Logger::Print("Waiting for database...\n"); | |||
| while (!Game::Sys_IsDatabaseReady()) std::this_thread::sleep_for(100ms); | |||
| }); | |||
|
|
|||
| Command::Add("poolUsages", []() | |||
There was a problem hiding this comment.
If you could make those commands 3 functions instead of defining their body in the constructor of FastFiles that would be better (when I add functions to IW4x that's what I'm trying to do from now on).
| @@ -565,6 +565,15 @@ namespace Components | |||
| return file; | |||
| } | |||
|
|
|||
| void enum_assets(const Game::XAssetType type, const std::function<void(Game::XAssetHeader, void*)> callback, const bool includeOverride) | |||
There was a problem hiding this comment.
I'm not sure that function is necessary (it's basically a forwarder to Game::DB_EnumXAsset, i don't feel like it does much more?) but asssuming it would be:
- I think this belongs in AssetHandler not FastFiles
- PascalCase for functions not snake_case please !
- Add it to the class as a private function rather than defining it in the CPP
| count++; | ||
| }, true); | ||
|
|
||
| Logger::Print(Utils::String::VA("%i %s: %i / %i\n", i, Game::g_assetNames[i], count, Game::g_poolSize[i])); |
There was a problem hiding this comment.
bad usage of logger. change to logger::print("{} {} etc etc")
learn more about c++20 format here https://en.cppreference.com/w/cpp/utility/format
| count++; | ||
| }, true); | ||
|
|
||
| Logger::Print(Utils::String::VA("%i %s: %i / %i\n", type, Game::g_assetNames[type], count, Game::g_poolSize[type])); |
| totalCount += Game::g_poolSize[i]; | ||
| } | ||
|
|
||
| Logger::Print(Utils::String::VA("total assets: %i / %i\n", count, totalCount)); |
| @@ -565,6 +565,15 @@ namespace Components | |||
| return file; | |||
| } | |||
|
|
|||
| void enum_assets(const Game::XAssetType type, const std::function<void(Game::XAssetHeader, void*)> callback, const bool includeOverride) | |||
There was a problem hiding this comment.
CamelCase + defined function as static member of fastfiles
| return; | ||
| } | ||
|
|
||
| const auto type = static_cast<Game::XAssetType>(std::atoi(params->get(1))); |
There was a problem hiding this comment.
lack of bounds checking i can enter a negative number in the console and this code will happily take it in
| @@ -39,7 +39,7 @@ namespace Game | |||
| typedef void(*DB_EnumXAssets_t)(XAssetType type, void(*)(XAssetHeader, void*), void* userdata, bool overrides); | |||
| extern DB_EnumXAssets_t DB_EnumXAssets; | |||
|
|
|||
| typedef void(*DB_EnumXAssets_Internal_t)(XAssetType type, void(*)(XAssetHeader, void*), void* userdata, bool overrides); | |||
| typedef void(*DB_EnumXAssets_Internal_t)(XAssetType type, void(*)(XAssetHeader, void*), const void* userdata, bool overrides); | |||
There was a problem hiding this comment.
modify your code to match the game's function definitions not the other way around
|
@Lierrmm Hello, any news? 😄 |
What does this PR do?
Adds 3 new commands that can be used for seeing the total number of xassets used.
How does this PR change IW4x's behaviour?
Existing behavior does not change.
poolUsages
poolUsage
<number>assetCount
poolUsages
poolUsage
<number>assetCount
Anything else we should know?
N/A
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)