fix: make .str parsing with ZB useful #160
Open
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diamante0018
force-pushed
the
fix/zb-str
branch
from
ec61d9b
to
2857c12
Compare
Rackover
requested changes
Nov 2, 2024
|
I should have addressed your review @Rackover |
|
This PR can be tested using the other PR I opened on the rawfiles repository btw as it's the first PR that reintroduces .str files to the rawfiles repo as they were previously removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes CoD4 str parsing exclusive to a flag. Undoing this default behaviour will make ZB modder friendly and can allow Louvenarde to undo the JSON localized string parsing from the IW4x rawfiles
How does this PR change IW4x's behaviour?
No longer adds prefix to localized strings derived from .str file name (CoD4 mod tools behaviour)
Anything else we should know?
No
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)