Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function fmin #9053

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Added function fmin #9053

merged 3 commits into from
Jan 3, 2023

Conversation

hyadav2k
Copy link
Contributor

Close #9009

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request labels Dec 23, 2022
@p3jitnath
Copy link
Contributor

p3jitnath commented Dec 25, 2022

Hi there @hyadav2k!
There seem to be conflicts in the ivy/functional/experimental/elementwise.py. Can you take a recent pull and resolve the merge conflicts? Also there seems to be some failing tests for the PR. Would you mind reviewing this once and try again?

@hyadav2k
Copy link
Contributor Author

hyadav2k commented Jan 2, 2023

Hi @nathzi1505, thanks for reviewing. The latest commits solves the merge conflicts. The failing tests are not arising due to the changes of this PR, I checked in master as well, and those tests failed.

Meanwhile test_fmin passes all four tests. Below is the o/p for the command pytest test_elementwise.py::test_fmin:

============================================================================================= test session starts =============================================================================================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /workspaces/ivy
plugins: metadata-2.0.4, typeguard-2.13.3, json-report-1.5.0, hypothesis-6.55.0
collected 4 items                                                                                                                                                                                             

test_elementwise.py ....                                                                                                                                                                                [100%]

============================================================================================== warnings summary ===============================================================================================
../../../../../../../usr/local/lib/python3.8/dist-packages/flatbuffers/compat.py:19
  /usr/local/lib/python3.8/dist-packages/flatbuffers/compat.py:19: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=================================================================================== 4 passed, 1 warning in 70.99s (0:01:10) ===================================================================================

Kindly review the latest commit. Thanks.

@p3jitnath
Copy link
Contributor

Looks good to me.

@p3jitnath p3jitnath closed this Jan 3, 2023
@p3jitnath p3jitnath reopened this Jan 3, 2023
@p3jitnath p3jitnath merged commit ac04ffd into ivy-llc:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fmin
3 participants