-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added function eigvals #8945
Merged
Merged
Added function eigvals #8945
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e73cb2b
Added function eigvals
hyadav2k 9cd7c86
fixed lint errors and merge conflicts
hyadav2k 1aaa20f
fixed format
hyadav2k 2ab7ae2
fixing lint errors
hyadav2k ee2271b
Merge remote-tracking branch 'origin' into eigvals
hyadav2k 6d48d9a
resolving lint errors
hyadav2k 9b852c1
Solve Merge conflicts
hyadav2k 9866cf6
fixed failing tests
hyadav2k ebec12e
minor docstring change
hyadav2k 8b24170
removes extra input argument
hyadav2k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,9 +59,18 @@ def matrix_exp( | |
|
||
|
||
def eig( | ||
x: Union[tf.Tensor], | ||
x: Union[tf.Tensor, tf.Variable], | ||
/, | ||
) -> Tuple[tf.Tensor]: | ||
if not ivy.dtype(x) in (ivy.float32, ivy.float64, ivy.complex64, ivy.complex128): | ||
return tf.linalg.eig(tf.cast(x, tf.float64)) | ||
return tf.linalg.eig(x) | ||
|
||
|
||
def eigvals( | ||
x: Union[tf.Tensor, tf.Variable], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly here: https://www.tensorflow.org/api_docs/python/tf/linalg/eigvals |
||
/, | ||
) -> Union[tf.Tensor, tf.Variable]: | ||
if not ivy.dtype(x) in (ivy.float32, ivy.float64, ivy.complex64, ivy.complex128): | ||
return tf.linalg.eigvals(tf.cast(x, tf.float64)) | ||
return tf.linalg.eigvals(x) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to change this line, as
eig
only expects Tensor as input as stated here: https://www.tensorflow.org/api_docs/python/tf/linalg/eigThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing, I made the necessary changes.