Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add count_nonzero extension #6295

Merged
merged 13 commits into from
Nov 10, 2022
Merged

Add count_nonzero extension #6295

merged 13 commits into from
Nov 10, 2022

Conversation

raghuveerbhat
Copy link
Contributor

Close #6284

@raghuveerbhat raghuveerbhat changed the title implement count_nonzero extension Add count_nonzero extension Oct 29, 2022
@ivy-leaves ivy-leaves added the Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards label Oct 29, 2022
@raghuveerbhat raghuveerbhat marked this pull request as ready for review October 29, 2022 19:42
MarShaikh
MarShaikh suggested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@MarShaikh MarShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you fix the merge conflicts first? With that I will be able to see whether tests are failing in the CI or not. Thanks!

@raghuveerbhat
Copy link
Contributor Author

I've resolved merge conflicts. Let me know if any other changes are needed.

@MarShaikh MarShaikh added the Ivy API Experimental Run CI for testing API experimental/New feature or request label Nov 8, 2022
MarShaikh
MarShaikh suggested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@MarShaikh MarShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I just made the CI run on the functions you wrote. Meanwhile can you resolve the merge conflicts? I will keep your PR in the top of my list so I can review this quicker and this doesn't happen again. Thanks!

@raghuveerbhat
Copy link
Contributor Author

raghuveerbhat commented Nov 8, 2022 •
edited
Loading

Hi @MarShaikh , thank you for keeping my PR on priority :). I've resolved merge conflicts now. I hope that i can ignore lint issue. Please let me know if any other changes are required.

@MarShaikh MarShaikh added Ivy API Experimental Run CI for testing API experimental/New feature or request and removed Ivy API Experimental Run CI for testing API experimental/New feature or request labels Nov 10, 2022
MarShaikh
MarShaikh approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@MarShaikh MarShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing! 🌟

@MarShaikh MarShaikh merged commit 5bb74e5 into ivy-llc:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarShaikh MarShaikh MarShaikh approved these changes

Assignees

@MarShaikh MarShaikh

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

count_nonzero
3 participants
@raghuveerbhat @MarShaikh @ivy-leaves