Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_softmax ivy functional API extension #4806

Merged
merged 10 commits into from
Sep 23, 2022
Merged

log_softmax ivy functional API extension #4806

merged 10 commits into from
Sep 23, 2022

Conversation

fnhirwa
Copy link
Contributor

@fnhirwa fnhirwa commented Sep 22, 2022

Close #4529

@fnhirwa fnhirwa added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Reformatting Ivy Functional API labels Sep 22, 2022
@fnhirwa fnhirwa added the Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide label Sep 22, 2022
iamjameskeane
iamjameskeane suggested changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@iamjameskeane iamjameskeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

I think this is currently failing tests at the minute, but Im sure you knew that already :)

@fnhirwa
Copy link
Contributor Author

fnhirwa commented Sep 23, 2022 •
edited
Loading

Yeah, I think it was due to directories that were incorrect in the testing script files but I see that they updated them🙂

iamjameskeane
iamjameskeane approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@iamjameskeane iamjameskeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamjameskeane iamjameskeane merged commit 0c57d9a into ivy-llc:master Sep 23, 2022
@fnhirwa fnhirwa deleted the log_softmax branch September 24, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamjameskeane iamjameskeane iamjameskeane approved these changes

Assignees

@iamjameskeane iamjameskeane

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide Ivy Functional API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log_softmax
2 participants
@fnhirwa @iamjameskeane