Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richard Orito #26712

Closed
wants to merge 2 commits into from
Closed

Richard Orito #26712

wants to merge 2 commits into from

Conversation

RichieOrito
Copy link

@RichieOrito RichieOrito commented Oct 6, 2023

feat: This pull request adds two new functions to the Ivy library: union_container and union_array. These functions return the union of two containers or arrays, respectively.

Related Issue

Close #26289

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@ivy-leaves ivy-leaves added Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Oct 9, 2023
@hmahmood24 hmahmood24 closed this Oct 9, 2023
@hmahmood24 hmahmood24 reopened this Oct 9, 2023
Copy link
Contributor

@hmahmood24 hmahmood24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RichieOrito, thanks for the PR. However, we need to implement the union function in all the backends along with the experimental and the data_classes APIs. We also need to implement one test in the experimental tests API. Furthermore, we need to remove any unnecessary files added e.g. the libssl file you commit. Please go through this PR to get a feel of how functions are supposed to be added to ivy and all the namespaces I mentioned above. Thanks!

@hmahmood24
Copy link
Contributor

Closing this PR since it has been stale for more than 2 weeks now.

@hmahmood24 hmahmood24 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

union
3 participants