Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the soft_margin loss #21073

Closed
wants to merge 0 commits into from
Closed

added the soft_margin loss #21073

wants to merge 0 commits into from

Conversation

sushmanthreddy
Copy link
Contributor

close #21072

@sushmanthreddy sushmanthreddy mentioned this pull request Jul 31, 2023
Closed
@ivy-leaves ivy-leaves added Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Jul 31, 2023
@sushmanthreddy
Copy link
Contributor Author

@kgmann can u plss review the pull request ?

@sushmanthreddy
Copy link
Contributor Author

@kgmann can u plss review the pull request ?

@kgmann can u pls review the pull request?

@kgmann
Copy link
Contributor

kgmann commented Aug 11, 2023

Hey @sushmanthreddy, thanks for your contribution, and sorry for my late reply.
Can you please make sure the test is passing ? It's currently failing.
You can run it locally with pytest ivy_tests/test_ivy/test_functional/test_experimental/test_nn/test_losses.py::test_soft_margin_loss.
Feel free to let me know when you encounter any issue. Thanks.

@kgmann
Copy link
Contributor

kgmann commented Aug 11, 2023 •
edited by ivy-branch
Loading

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

@sushmanthreddy
Copy link
Contributor Author

@kgmann the tests are now passing if paddle doesn't pass thats due to paddle bfloat16 issue.,where ivy people are working on .other than that ,i have implemented the loss function according to paper.

now testcases are passing and backend implementation is also there over here.Soft_margin_loss is only present in paddle and torch.so i have added in them.
Screenshot from 2023-08-18 16-05-23

here sc of testspassing

@sushmanthreddy
Copy link
Contributor Author

sushmanthreddy commented Aug 19, 2023 •
edited
Loading

@kgmann unsupported datatypes are checked this way and added to it and crossverified with doc also
Screenshot from 2023-08-20 02-40-35

@ivy-seed ivy-seed assigned Infrared1029 and unassigned kgmann Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Infrared1029 Infrared1029

Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

soft_margin_loss
4 participants
@sushmanthreddy @kgmann @Infrared1029 @ivy-leaves