Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linear_algebra.py #19287

Closed
wants to merge 1 commit into from
Closed

Update linear_algebra.py #19287

wants to merge 1 commit into from

Conversation

yluoc
Copy link

@yluoc yluoc commented Jul 12, 2023

update solve_triangular in ivy/functional/ivy/experimental/linear_algebra.py

Close #3856

update solve_triangular in ivy/functional/ivy/experimental/linear_algebra.py
@yluoc
Copy link
Author

yluoc commented Jul 12, 2023

update solve_triangular in [ivy/functional/ivy/experimental/linear_algebra.py]

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request labels Jul 12, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@yluoc yluoc closed this Jul 12, 2023
@yluoc yluoc reopened this Jul 12, 2023
@yluoc
Copy link
Author

yluoc commented Jul 12, 2023

Close #3856

@yluoc yluoc closed this Jul 12, 2023
@yluoc yluoc reopened this Jul 12, 2023
@kgmann
Copy link
Contributor

kgmann commented Aug 11, 2023

Hey @yluoc thanks for your contribution, but your work is incomplete. You have to implement the function in ivy's functional API and for each backend, and test. Please take a look at this https://lets-unify.ai/docs/ivy/overview/contributing/open_tasks.html#ivy-experimental-api and let me know if you have any other question. You can also take a look at how some of the functions have been implemented here to have a better idea of what to do.

@kgmann
Copy link
Contributor

kgmann commented Aug 11, 2023

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you hugs

Also @yluoc please follow the guidelines to create an issue and link the PR to it.

@ivy-seed ivy-seed added the Stale label Aug 22, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@ivy-seed ivy-seed assigned danielmunioz and unassigned kgmann Aug 29, 2023
@danielmunioz
Copy link
Contributor

Closing due to inactivity, as it's been more than 2 weeks without changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Ivy Functional API
5 participants