Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivy.lgamma #19177

Merged
merged 13 commits into from
Jul 19, 2023
Merged

ivy.lgamma #19177

merged 13 commits into from
Jul 19, 2023

Conversation

marccgrau
Copy link
Contributor

Close #19152

@ivy-leaves ivy-leaves added Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task labels Jul 10, 2023
@ivy-seed ivy-seed assigned sherry30 and unassigned DragosStoican Jul 11, 2023
sherry30
sherry30 suggested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Its best practice to complete 1 task per PR, it helps to keep things more organized.
Can you remove the tf frontend function . You can create a PR for that after this one.

Thanks

@marccgrau marccgrau requested a review from sherry30 July 13, 2023 12:04
sherry30
sherry30 suggested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review,

Requested 1 change

Thanks

ivy/functional/ivy/experimental/elementwise.py Outdated Show resolved Hide resolved
@marccgrau marccgrau requested a review from sherry30 July 18, 2023 06:30
sherry30
sherry30 suggested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few changes.

Can you add unsupported dtypes accordingly.
I think paddle doesn't support float16 the rest you can test and find out.

Thanks

ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py Outdated Show resolved Hide resolved
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py Outdated Show resolved Hide resolved
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py Outdated Show resolved Hide resolved
@marccgrau marccgrau requested a review from sherry30 July 18, 2023 12:19
sherry30
sherry30 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Thanks for the changes.

@sherry30 sherry30 merged commit c7ce1c7 into ivy-llc:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry30 sherry30 sherry30 approved these changes

Assignees

@sherry30 sherry30

Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lgamma
4 participants
@marccgrau @sherry30 @DragosStoican @ivy-leaves