Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivy.fill_diagonal #19072

Merged
merged 6 commits into from
Jul 11, 2023
Merged

ivy.fill_diagonal #19072

merged 6 commits into from
Jul 11, 2023

Conversation

mohame54
Copy link
Contributor

@mohame54 mohame54 commented Jul 9, 2023

close #19007

@ivy-leaves ivy-leaves added Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task labels Jul 9, 2023
@mohame54
Copy link
Contributor Author

mohame54 commented Jul 9, 2023

I am ready for the review @sherry30

@sherry30
Copy link
Contributor

sherry30 commented Jul 11, 2023 •
edited by ivy-branch
Loading

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

sherry30
sherry30 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sherry30 sherry30 merged commit e1015bc into ivy-llc:master Jul 11, 2023
@mohame54
Copy link
Contributor Author

thank you @sherry30

Ashwani132003 pushed a commit to Ashwani132003/ivy that referenced this pull request Jul 20, 2023
@mohame54 @sherry30 @Ashwani132003
ivy.fill_diagonal (ivy-llc#19072)
f97ff58 
Co-authored-by: sherry30 <[email protected]>
Ashwani132003 pushed a commit to Ashwani132003/ivy that referenced this pull request Jul 26, 2023
@mohame54 @sherry30 @Ashwani132003
ivy.fill_diagonal (ivy-llc#19072)
3bf5751 
Co-authored-by: sherry30 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry30 sherry30 sherry30 approved these changes

Assignees

@sherry30 sherry30

Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fill_diagonal
4 participants
@mohame54 @sherry30 @ivy-leaves @ivy-branch