EHN : ptp methos is add in Jax devicearray.py

[MuhammadNizamani]

closed #19048

[MuhammadNizamani]

@D0m-inic review this please

[D0m-inic]

Hi Muhammad, looks good to me. It looks to me like the dtype and axis values for the test can be obtained from already existing helper methods, could you explain your reasoning behind creating a new composite?

[MuhammadNizamani]

I want to check for shape . @D0m-inic I can change if you want.

[D0m-inic]

It looks to me like your st.composite seems to be quite similar in functionality to helpers.dtype_values_axis which you could use?

[MuhammadNizamani]

It looks to me like your st.composite seems to be quite similar in functionality to helpers.dtype_values_axis which you could use?

@D0m-inic What should I do ? should I change my test method??

[D0m-inic]

From what I see, you can get rid of your created @st.composite, as it is similar in functionality to the helpers.dtype_values_axis function, and in the @handle_frontend_method wrapper, when passing in dtype_and_x_axis_dtype, make a call to helpers.dtype_values_axis instead.

If you have a reason to use your custom composite that i'm overlooking, please let me know 😄

[MuhammadNizamani]

@D0m-inic I have make changes that you asked for and all test are passing.

[D0m-inic]

Hi Muhammad, just checked your PR and it seems some tests are failing, due to complex values types not being allowed.

I see some merge conflicts too? I know about the clone PR of this function being erroneously merged already, but @juliagsy said she already resolved the conflicts so I'm assuming its just something small :)

[MuhammadNizamani]

@D0m-inic I will resolve the issue and then I will mention you server

[D0m-inic]

👍

[MuhammadNizamani]

All tests passed on

[D0m-inic]

Hey Muhammad, could you remove the shape parameter from dtype_values_axis for random shapes in testing? (This would also mean adding the valid_axis=True and min_num_dims=1 parameters to prevent illegal inputs).

Also, you can change the value of helpers.get_dtpyes to be "float" instead of "numeric", and then remove the conditionals for the complex numbers.

After these changes i'm happy to merge 😃

[MuhammadNizamani]

Sure thanks

[MuhammadNizamani]

@D0m-inic I have made changes that you asked for

[D0m-inic]

LGTM 👍