Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: ivy experimental api frombuffer #13781

Merged
merged 14 commits into from
Apr 9, 2023

Conversation

trantuantdt
Copy link
Contributor

@trantuantdt trantuantdt commented Apr 6, 2023

Close #13495

Copy link
Contributor

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some linting errors, please fix them in your files (pre-commit is recommended) and check the requested changes, other than that everything LGTM

@trantuantdt
Copy link
Contributor Author

There is a linting error, but not from my code. Could you please review my code? Thank!

Copy link
Contributor

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@MahmoudAshraf97 MahmoudAshraf97 merged commit c950666 into ivy-llc:master Apr 9, 2023
VickyThawne pushed a commit to VickyThawne/ivy that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frombuffer
3 participants