-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frexp implementation #11182
frexp implementation #11182
Conversation
@pillarxyz Looks mostly good, a couple comments:
|
there is an error when I dont add the if out is None: numpy: frexp: 'out' must be a tuple of arrays I think I added that to the type hints but I think I should specify that out must be a tuple in the tests |
humm, I dont seem to get that error myself when I run the tests |
If you take a look at the intelligent tests you can see a falsifying example for the frexp function which shows the following error |
I think I solved it by making (None, None) the default if out is not set |
Looks good to go, thanks ! |
Co-author: pillarxyz <[email protected]>, nassimberrada <Nassim>
#10844