gulp-typescript doesn't resolve @types in outter node_modules

[FunkMonkey]

Expected behavior:
With a project structure like this, which uses Yarn workspaces

- workspace
  - node_modules
    - @types
      - node
  - packages
    - package-to-compile
      - tsconfig.json

there should not be compiler errors like error TS2304: Cannot find name 'require'. or error TS2688: Cannot find type definition file for 'node'. (after adding node to types in tsconfig.json.

Actual behavior:

Getting error TS2304: Cannot find name 'require'.

Your gulpfile:

const gulp = require( "gulp" );
const typescript = require( "gulp-typescript" );

const SRC_GLOB =  "./src/**/*.ts";

var tsProject = typescript.createProject( 'tsconfig.json' );

gulp.task( "build:scripts", function() {
  return gulp.src( SRC_GLOB )
    .pipe( tsProject() )
    .pipe( gulp.dest( "build" ) );
});

tsconfig.json

{
    "compilerOptions": {
        "module": "commonjs",
        "noImplicitAny": true,
        "target": "es2015"
    },
}

Code

import { Observable } from 'rxjs';
import { IPluginLoadInfo } from './iplugininfo';

export default {
  require( { id }: IPluginLoadInfo ) {
    const mod = require( id );
    return Observable.of( { id, factory: mod.default || mod } );
  }
};

---

Just using tsc works flawlessly, so it must be something inside gulp-typescript!

[FunkMonkey]

Ups. Just saw #515 and the solution was just to do gulp.src( SRC_GLOB, { cwd: 'src' } ).

Thanks anyway!

[FunkMonkey]

Nope, didn't work after all (just didn't do anything in the end because the SRC_GLOB was wrong then of course). Could it be related to #422 ?

[ivogabe]

I haven't used yarn workspaces myself, so I'm not familiar with those. Could you create a basic example that illustrates the problem, which I can clone and install to see the bug?

[ivogabe]

Is this still an issue?

[FunkMonkey]

Sorry, I was quite busy. I'll test it once I have a little time at the end of september and will create that basic example for you!

Thanks for your patience :)

[iby]

@ivogabe it is. Trying to migrate an old project and can't get my head around this. Works if add symbolic link for node_modules inside the build folder.

[FunkMonkey]

@ivogabe Alright, I finally managed to create a test case:
https://github.com/FunkMonkey/gulp-typescript-bug

just do

yarn install
npm run build-gulp
npm run build-tsc

I tested it on windows, not sure if the run commands work from the workspace on a different OS. If not, just go to packages/typescript-test and do npm run build-gulp or npm run build-tsc there.

As you see npm run build-tsc works, while npm run build-gulp doesnt...

Thanks a lot!

[FunkMonkey]

@ivogabe any update on this? Thanks!

[FunkMonkey]

@ivogabe

OK, I digged a lot and found the problem. For whatever reason typescript does not traverse the parent node_modules folders when the configFilePath in the parsed compiler options is not an absolute path!!

The problem lies in main.ts#222. Just remove path.basename there and maybe replace it with path.resolve( process.cwd(), tsConfigFileName ) or anything else that makes sense. I just tried it and it works.

Thank you very much!

[pixnblox]

I just had the same problem... took me quite a long (and frustrating) time to test options and search for solutions, but I eventually found this issue. Thanks @FunkMonkey for logging it!

[norech]

Another solution is to use yarn nohoist feature with "**/@types/**" pattern, on the root project.
You will need to install typings dependencies inside of every subprojects, but at least it works without forking gulp-typescript or using tricky gulp files.

It would be great if this issue was fixed. It could avoid to a lot of people to spend a lot of hours to find why theirs projects are not building, and how to fix it.

[ivogabe]

Sorry for the late reply. Thanks @FunkMonkey for the debugging! @lddubeau has opened a PR, I'll review that tomorrow. So we'll have this issue fixed soon!