Fixes for SerenityOS #689
Closed
Fixes for SerenityOS #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmai
reviewed
Dec 15, 2024
|
Okay, looks good, except for the comment regarding MPROTECT_VDB! I will process the PR in several day. |
This causes a null pointer dereference crash when building without SMALL_CONFIG. See: ivmai#688
SerenityOS only supports MADV_SET_VOLATILE/MADV_SET_NONVOLATILE and returns EINVAL for MADV_DONTNEED: https://github.com/SerenityOS/serenity/blob/b88cd185a0ec40fc10405b555507aa6f0aab8222/Kernel/Syscalls/mmap.cpp#L355-L388 See: ivmai#688
linusg
force-pushed
the
serenity-fixes
branch
from
87821a6 to
ed1af4f
Compare
I would prefer the next port update to be dropping serenity's patches altogether, happy to wait for this PR to be merged first :) |
ivmai
pushed a commit
that referenced
this pull request
Dec 20, 2024
(fix of commit b48ee2b) PR #689 (bdwgc). As of now, Serenity OS only supports `MADV_SET_VOLATILE` and `MADV_SET_NONVOLATILE` as `advice` argument to `madvise()`. The later returns `EINVAL` for other `advice` values (including `MADV_DONTNEED`). * os_dep.c [USE_MUNMAP && !USE_WINALLOC && !SN_TARGET_PS3 && SERENITY] (block_unmap_inner): Call `mmap(PROT_NONE)` instead of `mprotect(PROT_NONE)` and `madvise(MADV_DONTNEED)`.
ivmai
pushed a commit
that referenced
this pull request
Dec 20, 2024
(fix of commit b48ee2b) PR #689 (bdwgc). For an unknown reason, enabling of incremental mode based on `mprotect` causes a null pointer dereference in `GC_finish_collection()`. This patch removes `define MPROTECT_VDB` for Serenity OS. * include/private/gcconfig.h [SERENITY] (MPROTECT_VDB): Do not define. * os_dep.c [MPROTECT_VDB && !DARWIN && !MSWIN32 && !MSWINCE && SERENITY] (CODE_OK): Likewise. * os_dep.c [MPROTECT_VDB && !DARWIN && !USE_WINALLOC && !AIX && !CYGWIN32 && !HAIKU]: Include `sys/syscall.h` regardless of `SERENITY`.
|
Merged. Please test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages and #688 for details.