Test zig build on MacOS too #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivmai looking at the workflow https://github.com/actonlang/bdwgc/actions/runs/7475855579 it seems like it fails with threads enabled but thread local allocation disabled. Not sure I'm reading it right though so probably better you take a look? |
ivmai
reviewed
Jan 10, 2024
The code w/o thread-local allocation runs slower thus the test exceeds 4 minutes, pleasse change it to 6 (should be enough). |
It seems to run slightly slower on MacOS.
|
Are shared builds OK on MacOS? |
|
Merged as 9464650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds so the zig build test runs natively on MacOS too.
Part of #602.