zig: Add cflags_extra option #607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not work for 2 options. E.g. |
ivmai
reviewed
Jan 10, 2024
plajjan
force-pushed
the
zig-cflags-extra
branch
from
346209b to
383b2ac
Compare
I was afraid of that it would require separating them... I'll have a look! |
|
@ivmai hmm, actually, are you sure? both |
Please check it on gctest.c. (I mean |
This passes through extra options to the compiler. No validation is performed, the values are split on space and passed in as separate flags.
plajjan
force-pushed
the
zig-cflags-extra
branch
from
383b2ac to
3f51614
Compare
|
Ok, I see what you mean @ivmai. I am getting the same result, yet the --verbose output does say the flags are passed. I guess the way it prints them to me and the way they are actually paseed somehow differs. |
|
@ivmai simply splitting it up in parts and appending each to the flags works. I just pushed an update. |
ivmai
pushed a commit
that referenced
this pull request
Jan 11, 2024
PR #607 (bdwgc). This passes through extra options (flags) to the C compiler. No flags validation is performed; the values given in CFLAGS_EXTRA are split on a space and append to compiler flags one by one. * build.zig (cflags_extra): New option (an empty string by default). * build.zig (flags): Append space-separated flags from cflags_extra (after all other flags are appended); remove relevant TODO item.
|
Merged as 70c9e87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes through extra options to the compiler. No validation is performed, the value is passed through as-is.
Part of #602