-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Mp3Compression transform #38
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 99.11% 97.13% -1.98%
==========================================
Files 4 4
Lines 450 523 +73
==========================================
+ Hits 446 508 +62
- Misses 4 15 +11
Continue to review full report at Codecov.
|
This approach may be better: |
83a9685
to
1b01e6b
Compare
Actually, I think we should support both backends. Pros/cons: lameenc:Pros: More flexible parameters. Faster than pydub/ffmpeg. Cons: Introduces latency in the audio pydub/ffmpegPros: Does not introduce latency in the audio Cons: Slower than lameenc |
5a21bd1
to
636e17a
Compare
It's not really ideal, since it writes to disk, but at least it is functional.
Close #37