Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Mp3Compression transform #38

Merged
merged 11 commits into from
Sep 23, 2020
Merged

Implement Mp3Compression transform #38

merged 11 commits into from
Sep 23, 2020

Conversation

iver56
Copy link
Owner

@iver56 iver56 commented Apr 7, 2020

It's not really ideal, since it writes to disk, but at least it is functional.

Close #37

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #38 into master will decrease coverage by 1.97%.
The diff coverage is 89.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   99.11%   97.13%   -1.98%     
==========================================
  Files           4        4              
  Lines         450      523      +73     
==========================================
+ Hits          446      508      +62     
- Misses          4       15      +11     
Impacted Files Coverage Δ
audiomentations/core/utils.py 94.11% <75.00%> (-2.55%) ⬇️
audiomentations/augmentations/transforms.py 97.45% <90.00%> (-2.00%) ⬇️
audiomentations/core/transforms_interface.py 96.87% <0.00%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d0c11...c12a34e. Read the comment docs.

@iver56
Copy link
Owner Author

iver56 commented Apr 20, 2020

@iver56 iver56 force-pushed the ij/mp3-compression branch 2 times, most recently from 83a9685 to 1b01e6b Compare May 18, 2020 16:08
@iver56 iver56 changed the title Implement Mp3Compression transform, which depends on pydub and ffmpeg Implement Mp3Compression transform May 19, 2020
@iver56
Copy link
Owner Author

iver56 commented Sep 23, 2020

Actually, I think we should support both backends. Pros/cons:

lameenc:

Pros: More flexible parameters. Faster than pydub/ffmpeg.

Cons: Introduces latency in the audio

pydub/ffmpeg

Pros: Does not introduce latency in the audio

Cons: Slower than lameenc

@iver56 iver56 merged commit d1c62ef into master Sep 23, 2020
@iver56 iver56 deleted the ij/mp3-compression branch September 23, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a transformation that adds mp3 or vorbis compression artifacts
1 participant